Add GDAL_NODATA tag to exported TIFF #5229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grantim
approved these changes
Oct 13, 2025
Fedr
reviewed
Oct 13, 2025
| // load values from tiff to ouput.data | ||
| MRMESH_API Expected<void> readRawTiff( const std::filesystem::path& path, RawTiffOutput& output ); | ||
|
|
||
| struct WriteRawTiffParams |
There was a problem hiding this comment.
may be better derive:
struct WriteRawTiffParams : BaseTiffParameters
source/MRMesh/MRTiffIO.h
Outdated
Comment on lines
81
to
84
| // optional transformation data written to GeoTIFF's ModelTransformationTag | ||
| const AffineXf3f* xf = nullptr; | ||
| // optional NoData value written to GDAL_NODATA | ||
| std::optional<std::string> noData; |
There was a problem hiding this comment.
inconsistency: one optional parameter is passed using pointer, and the other using std::optional
Fedr
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.