Only use voxels to construct a base element, then repeat it. #5227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, applying the same idea as for cellular structures but for TPMS. This should drastically reduce memory consumption and improve performance.
Fedr
approved these changes
Oct 12, 2025
source/MRVoxels/MRFillingSurface.cpp
Outdated
| return res; | ||
| const float period = 1.f / params.frequency; | ||
| const auto voxelSize = getDimsAndSize( size, params.frequency, params.resolution ).size; | ||
| const float minVoxelSize = std::min( voxelSize.x, std::min( voxelSize.y, voxelSize.z ) ); |
There was a problem hiding this comment.
Suggested change
| const float minVoxelSize = std::min( voxelSize.x, std::min( voxelSize.y, voxelSize.z ) ); | |
| const float minVoxelSize = std::min( { voxelSize.x, voxelSize.y, voxelSize.z } ); |
| } | ||
| return res; | ||
|
|
||
| MeshBuilder::uniteCloseVertices( result, maxVoxelSize ); |
There was a problem hiding this comment.
it is better to call uniteCloseVertices( result, 0 ), or very small value if rounding errors are inevitable
There was a problem hiding this comment.
The basic element is created from voxels, thus we cannot guarantee the precision smaller than the voxel size.
Fedr
pushed a commit
that referenced
this pull request
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, applying the same idea as for cellular structures but for TPMS. This should drastically reduce memory consumption and improve performance.