Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove setup/call/teardown steps #38

Merged

Conversation

jd
Copy link
Member

@jd jd commented Dec 27, 2024

This creates 3x more spans for each test which is too verbose.

This creates 3x more spans for each test which is too verbose.

Change-Id: I231dbdb610669e6aa691e5f08a3b261a1b7a13e4
Copy link

mergify bot commented Dec 27, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Approval

Wonderful, this rule succeeded.
  • #approved-reviews-by >= 1

🟢 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = test (3.10)
    • check-success = test (3.11)
    • check-success = test (3.12)
    • check-success = test (3.13)

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@mergify mergify bot requested a review from a team December 27, 2024 14:11
@mergify mergify bot merged commit 883371e into main Dec 27, 2024
9 checks passed
@mergify mergify bot deleted the devs/jd/remove-steps/I231dbdb610669e6aa691e5f08a3b261a1b7a13e4 branch December 27, 2024 14:45
@mergify mergify bot added queued and removed queued labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants