Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use synchronous batch span #36

Merged

Conversation

jd
Copy link
Member

@jd jd commented Dec 23, 2024

This makes sure the spans are emitted at the end of the test and not during the
run, making it easier to parse.

Depends-On: #33

jd added 2 commits December 23, 2024 18:13
This can interfere with tests otherwise.

Change-Id: I5558af45e522af02e702cd61ae7d2e4b2dcde5ce
This makes sure the spans are emitted at the end of the test and not during the
run, making it easier to parse.

Change-Id: I37f754f6cc1a48946f371999c9e3da59fcd35a3c
@jd
Copy link
Member Author

jd commented Dec 23, 2024

This pull request is part of a stack:

  1. test: make sure to delete PYTEST_MERGIFY_DEBUG (#33)
  2. chore: use synchronous batch span (#36) 👈

Copy link

mergify bot commented Dec 23, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 ⛓️ Depends-On Requirements

Wonderful, this rule succeeded.

Requirement based on the presence of Depends-On in the body of the pull request

🟢 Approval

Wonderful, this rule succeeded.
  • #approved-reviews-by >= 1

🟢 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = test (3.10)
    • check-success = test (3.11)
    • check-success = test (3.12)
    • check-success = test (3.13)

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@mergify mergify bot requested a review from a team December 23, 2024 17:19
Base automatically changed from devs/jd/clean-env/I5558af45e522af02e702cd61ae7d2e4b2dcde5ce to main December 23, 2024 17:43
@mergify mergify bot added the queued label Dec 23, 2024
@mergify mergify bot merged commit ccc3e72 into main Dec 23, 2024
9 checks passed
@mergify mergify bot deleted the devs/jd/clean-env/I37f754f6cc1a48946f371999c9e3da59fcd35a3c branch December 23, 2024 17:45
@mergify mergify bot removed the queued label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants