refactor: replace pytest-opentelemetry by our own code #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is part of a stack:
|
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 ApprovalWonderful, this rule succeeded.
🟢 Continuous IntegrationWonderful, this rule succeeded.
🟢 Changelog requirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
|
Base automatically changed from
devs/jd/no-pytest-opentelemetry/I3e0ed4dfe17a4af54cb014aa4b60951753da658c
to
main
December 26, 2024 12:32
|
@jd this pull request is now in conflict 😩 |
- This leverages more standard names for events, following OpenTelemetry recommendations https://opentelemetry.io/docs/specs/semconv/attributes-registry/test/ Change-Id: I67a8a985fa3ea35c08b027d4e8f94b1a88ae50c6
jd
force-pushed
the
devs/jd/no-pytest-opentelemetry/I67a8a985fa3ea35c08b027d4e8f94b1a88ae50c6
branch
from
46f6f0f to
d41c49b
Compare
Greesb
approved these changes
Dec 26, 2024
mergify
bot
deleted the
devs/jd/no-pytest-opentelemetry/I67a8a985fa3ea35c08b027d4e8f94b1a88ae50c6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recommendations
https://opentelemetry.io/docs/specs/semconv/attributes-registry/test/