Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set correct URL for upload #22

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: set correct URL for upload #22

merged 1 commit into from
Dec 17, 2024

Conversation

jd
Copy link
Member

@jd jd commented Dec 17, 2024 •
edited
Loading

No description provided.

@jd
Copy link
Member Author

jd commented Dec 17, 2024 •
edited
Loading

This pull request is part of a stack:

  1. fix: set correct URL for upload (#22) 👈

@jd jd mentioned this pull request Dec 17, 2024
Merged
@mergify Mergify
Copy link

mergify bot commented Dec 17, 2024 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Approval

Wonderful, this rule succeeded.
  • #approved-reviews-by >= 1

🟢 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = test (3.10)
    • check-success = test (3.11)
    • check-success = test (3.12)
    • check-success = test (3.13)

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

Greesb
Greesb previously approved these changes Dec 17, 2024
View reviewed changes
Base automatically changed from devs/jd/fix-exporter/Ie7f05a27df8c1e72937dd4880d3680e84759bb88 to main December 17, 2024 16:33
@mergify Mergify
Copy link

mergify bot commented Dec 17, 2024

@jd this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Dec 17, 2024
Syffe
Syffe previously approved these changes Dec 17, 2024
View reviewed changes
@jd
fix: set correct URL for upload
f3b20ad 
Change-Id: I8aed2d333d1cb0be40abb4ebe21bc51686a2dade
@jd jd force-pushed the devs/jd/fix-exporter/I8aed2d333d1cb0be40abb4ebe21bc51686a2dade branch from f11ca9a to f3b20ad Compare December 17, 2024 16:37
@mergify mergify bot removed the conflict label Dec 17, 2024
@mergify mergify bot dismissed stale reviews from Greesb and Syffe December 17, 2024 16:37

Pull request has been modified.

@mergify mergify bot requested a review from a team December 17, 2024 16:38
@mergify mergify bot merged commit 86e3bb6 into main Dec 17, 2024
14 checks passed
@mergify mergify bot deleted the devs/jd/fix-exporter/I8aed2d333d1cb0be40abb4ebe21bc51686a2dade branch December 17, 2024 16:39
@mergify mergify bot added queued and removed queued labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Greesb Greesb Greesb approved these changes

@DouglasBlackwood DouglasBlackwood DouglasBlackwood approved these changes

@Syffe Syffe Syffe left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jd @DouglasBlackwood @Greesb @Syffe