-
Notifications
You must be signed in to change notification settings - Fork 8
Add arg alpha
to gs_bound_summary()
to report multiple efficacy bounds
#535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
https://www.ascii-code.com/character/%CE%B1 W checking R files for non-ASCII characters ... Found the following file with non-ASCII characters: gs_bound_summary.R Portable packages must use only ASCII characters in their R code, except perhaps in comments. Use \uxxxx escapes for other characters.
Thank you, @jdblischak! Here, please find my answer to the questions above.
Yes. If it is WLR design, some rownames are changed.
The design objects created by |
I was specifically asking about the new argument Specifically, in #522, you describe how to use |
Does that mean it is ok if |
Yes, you are correct that we need |
Yes |
@LittleBeannie Thanks for answering my questions! I updated my original description above with these additional details. This PR is ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jdblischak! It looks good to me.
Closes #522
xref: #468, #515
Still some open questions:
gs_bound_summary
for supporting multiple alpha #522 (comment))gs_update_wlr()
has been added (Add argalpha
togs_bound_summary()
to report multiple efficacy bounds #535 (comment))gs_power_ahr()
? Currently I don't treat them any different that design objects created bygs_design_ahr()
(Generalizegs_bound_summary
for supporting multiple alpha #522 (comment))x[["input"]][["alpha"]]
for objects created by either function (Add argalpha
togs_bound_summary()
to report multiple efficacy bounds #535 (comment))