-
Couldn't load subscription status.
- Fork 1.8k
Feature/easy animation #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jjvarghese
wants to merge
4
commits into
MengTo:master
Choose a base branch
from
jjvarghese:feature/easyAnimation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,7 +103,7 @@ public class Spring : NSObject { | |
| private var transform : CGAffineTransform { get { return view.transform } set { view.transform = newValue }} | ||
| private var alpha: CGFloat { get { return view.alpha } set { view.alpha = newValue } } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test msg |
||
|
|
||
| public enum AnimationPreset: String { | ||
| public enum AnimationPreset: String, CaseIterable { | ||
| case SlideLeft = "slideLeft" | ||
| case SlideRight = "slideRight" | ||
| case SlideDown = "slideDown" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // The MIT License (MIT) | ||
| // | ||
| // Copyright (c) 2015 Meng To ([email protected]) | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in all | ||
| // copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| // SOFTWARE. | ||
|
|
||
| import Foundation | ||
|
|
||
| /** | ||
| An extension for convenience methods applicable to all Springable objects relating to animation. | ||
| */ | ||
| public extension Springable { | ||
|
|
||
| /** | ||
| A convenience method for animating any Springable object directly with the given `Spring.AnimationPreset` with an additional optional completion handler. | ||
|
|
||
| - Parameter animation: The animation type to animate from `Spring.AnimationPreset`. This will overwrite any previously set animations. | ||
| - Parameter completion: Optional completion handler for this method. Defaults to nil. | ||
| */ | ||
| func animate(withAnimation animation: Spring.AnimationPreset, | ||
| withCompletion completion: (() -> ())? = nil) { | ||
| self.animation = animation.rawValue | ||
| self.animateNext { | ||
| completion?() | ||
| } | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // | ||
| // Springable+AnimateTests.swift | ||
| // SpringAppTests | ||
| // | ||
| // Created by Joshua James Varghese on 19.06.21. | ||
| // Copyright © 2021 Meng To. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
| import XCTest | ||
| import Spring | ||
|
|
||
| class SpringableAnimateTests: XCTestCase { | ||
|
|
||
| let springView = SpringView() | ||
|
|
||
| func testAnimationPropertySetCorrectly() { | ||
| for animationType in Spring.AnimationPreset.allCases { | ||
| springView.animate(withAnimation: animationType) | ||
|
|
||
| XCTAssertEqual(springView.animation, animationType.rawValue) | ||
| } | ||
| } | ||
|
|
||
| } | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waht's this means,test msg