fix: salvage partial L3 abstraction drafts#2054
Draft
RerankerGuo wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1668.
L3 abstraction now normalizes partially structured provider output before deciding whether to reject it. Salvageable drafts can use string or object entries for
environment,inference, andconstraints; common label, description, and evidence aliases are normalized; tag strings are split into arrays; and a missing title can be derived from recovered content.Drafts that remain completely empty after normalization still fail with
LLM_OUTPUT_MALFORMED, so unusable output is not persisted.Related Issue (Required): Fixes #1668
Type of change
How Has This Been Tested?
cd apps/memos-local-plugin && npm test -- --run tests/unit/memory/l3/abstract.test.tspassed with 8 tests.cd apps/memos-local-plugin && npm run lintpassed.make formatcould not run in this environment becausepoetryis not installed:make: poetry: Command not found.Checklist: