fix: quarantine stale sqlite native binding#2049
Draft
RerankerGuo wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue (Required): Fixes #1343
Handles stale
better-sqlite3native bindings left behind after OpenClaw plugin updates.Postinstall already detects
NODE_MODULE_VERSIONmismatches and attemptsnpm rebuild better-sqlite3, but the stale.nodefile was left in place. On Windows update paths this can leave the old ABI artifact visible to the next startup/rebuild check. This change quarantines the mismatched native binding before running the rebuild, falling back to removal if the rename fails.The existing native binding validator remains the source of truth for deciding whether the binding is loadable. Other load errors are not quarantined.
Type of change
How Has This Been Tested?
Commands run:
Result:
native binding quarantine checks passed.Also attempted:
npm testis blocked becausevitestis not installed.npm run buildis blocked becausetscis not installed.make formatis blocked becausepoetryis not installed.Checklist