fix: avoid blocking OpenClaw plugin registration#2044
Draft
RerankerGuo wants to merge 2 commits into
Draft
Conversation
# Conflicts: # apps/memos-local-openclaw/index.ts
Collaborator
|
Automated Test Results: QUEUED Conflict with
I will post the final pass/fail result when the run completes. |
Collaborator
|
Automated Test Results: PASSED Cloud test-engine rerun against
Manual code review is still required before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue (Required): Fixes #1778
Removes the synchronous
better-sqlite3auto-rebuild path from OpenClaw plugin registration.The plugin already has
ensureSqliteBinding(ctx.log)as the central native binding preparation step. The removed registration-time fallback could runnpm rebuild better-sqlite3with a 120 second timeout before the service lifecycle was registered, which can make the plugin appear to fail loading during OpenClaw startup. Keeping binding preparation in one path avoids blocking registration and preserves the existing prebuild/rebuild handling.A regression test guards against reintroducing a registration-time
spawnSync/npm rebuildpath.Type of change
How Has This Been Tested?
Commands run:
Result:
startup registration static check passed.Also attempted:
npm testis blocked becausevitestis not installed.npm run buildis blocked becausetscis not installed.make formatis blocked becausepoetryis not installed.Checklist