Skip to content

feat: route embedding input types by usage#2024

Draft
RerankerGuo wants to merge 1 commit into
MemTensor:mainfrom
RerankerGuo:fix/embedding-input-type-routing
Draft

feat: route embedding input types by usage#2024
RerankerGuo wants to merge 1 commit into
MemTensor:mainfrom
RerankerGuo:fix/embedding-input-type-routing

Conversation

@RerankerGuo

Copy link
Copy Markdown

Summary

  • Fixes Support input_type for asymmetric embeddings in built-in memorySearch #1421.
  • Add optional inputType, queryInputType, and documentInputType embedding config fields.
  • Route document embeddings through documentInputType and query embeddings through queryInputType, falling back to inputType when a specific value is absent.
  • Forward input_type to OpenAI-compatible and OpenClaw host embedding requests when configured.
  • Retry the viewer embedding model probe once with input_type: "query" when a provider explicitly reports that input_type is required.

Validation

  • static embedding input_type checks passed
  • npm test -- --run tests/embedding-input-type.test.ts (blocked: vitest: not found)
  • npm run build (blocked: tsc: not found)
  • npm run lint (blocked: eslint: not found)
  • make format (blocked: poetry: Command not found)

@Memtensor-AI Memtensor-AI changed the base branch from main to dev-v2.0.22 July 2, 2026 02:23
@Memtensor-AI

Copy link
Copy Markdown
Collaborator

Automated Test Results: PASSED

Cloud test-engine full-audit rerun against dev-v2.0.22 completed successfully after clearing the cloud workspace disk.

  • Run: tr-678431ce-070 on cloud test-engine 10011
  • memos_local_openclaw/unit: 12 passed, 0 failed, 0 skipped

Manual code review is still required before merge.

@CarltonXiang CarltonXiang deleted the branch MemTensor:main July 3, 2026 07:25
@syzsunshine219 syzsunshine219 reopened this Jul 3, 2026
@syzsunshine219 syzsunshine219 added the needs-audit Requires manual audit before merge label Jul 3, 2026
@syzsunshine219 syzsunshine219 changed the base branch from dev-v2.0.22 to main July 3, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-audit Requires manual audit before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support input_type for asymmetric embeddings in built-in memorySearch

4 participants