Skip to content

fix: add is_reorganize check in _add_memories_parallel#1952

Open
bodhibudd wants to merge 1 commit into
MemTensor:mainfrom
bodhibudd:fix-mem
Open

fix: add is_reorganize check in _add_memories_parallel#1952
bodhibudd wants to merge 1 commit into
MemTensor:mainfrom
bodhibudd:fix-mem

Conversation

@bodhibudd

Copy link
Copy Markdown

_add_memories_parallel add is_reorganize check

Description

The _add_memories_parallel method does not check whether is_reorganize is True when calling _add_to_graph_memory to add memories to the graph

Related Issue (Required): Fixes #issue_number

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Test
  • Test Script Or Test Steps (please provide)
  • Pipeline Automated API Test (please provide)

Checklist

  • I have performed a self-review of my own code | 我已自行检查了自己的代码
  • I have commented my code in hard-to-understand areas | 我已在难以理解的地方对代码进行了注释
  • I have added tests that prove my fix is effective or that my feature works | 我已添加测试以证明我的修复有效或功能正常
  • I have created related documentation issue/PR in MemOS-Docs (if applicable) | 我已在 MemOS-Docs 中创建了相关的文档 issue/PR(如果适用)
  • I have linked the issue to this PR (if applicable) | 我已将 issue 链接到此 PR(如果适用)
  • I have mentioned the person who will review this PR | 我已提及将审查此 PR 的人

Reviewer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed
  • Tests have been provided

_add_memories_parallel add is_reorganize check
@bodhibudd bodhibudd changed the title Update manager.py fix: add is_reorganize check in _add_memories_parallel Jun 21, 2026
@Memtensor-AI Memtensor-AI changed the base branch from main to dev-v2.0.22 July 1, 2026 13:15
@Memtensor-AI

Copy link
Copy Markdown
Collaborator

Cloud AutoDev retest on dev-v2.0.22: PASSED.

Run: tr-1a021787-5a6 on test-engine-v3.
Scope: memos_python_core changed-python-source validation.
Result: 2/2 passed.

This replaces the earlier stale Python smoke failure caused by a baseline test corpus mismatch.

@Memtensor-AI

Copy link
Copy Markdown
Collaborator

Automated Test Results: PASSED

Cloud test-engine rerun against dev-v2.0.22 completed successfully.

  • Run: tr-3f3d8b4a-42c on cloud test-engine 10010
  • memos_python_core/changed-python-source: 2 passed, 0 failed, 0 skipped

Manual code review is still required before merge.

@CarltonXiang CarltonXiang deleted the branch MemTensor:main July 3, 2026 07:25
@syzsunshine219 syzsunshine219 reopened this Jul 3, 2026
@syzsunshine219 syzsunshine219 added the needs-audit Requires manual audit before merge label Jul 3, 2026
@syzsunshine219 syzsunshine219 changed the base branch from dev-v2.0.22 to main July 3, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-audit Requires manual audit before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants