bugfix: icon not showing in the firefox browser #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Contributor
but for some helpful feedback this PR wont fix it because the build tool is adding hashes to the assets based on vite Static Asset Handling. 
I think the path forward would be to kill off cc @Melkeydev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi guys. i am not able to see the website icon on firefox browser tab. i use this site a lot, kudos great simple easy to use product. it annoys me a little bit as i pin my websites in my browser when i dont see the icon lol.
The issue i found was the reference of the image icons was wrong. i have checked by deploying locally. it is working alright. let me know if we can merge this change and deploy hopefully.
please feel free to review the changes if you find something wrong. thanks and regards.