Skip to content

support serializing a vector of strings #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented Nov 13, 2024

Could probably relax it to allow any vectors (eg numbers)?..

@clarkevans
Copy link
Contributor

@aplavin -- thank you for the pull request.

I'm trying to grok the use cases for this, what are upsides and downsides? Anyway, we're going to be building out an IDE based upon FunSQL over at PlutoFunSQL.jl and putting together a roadmap here.

@aplavin
Copy link
Contributor Author

aplavin commented May 19, 2025

This PR simply adds supports for vectors, as in Lit(["a", "b", "c"]). It works fine in my experience (would be nice to finally merge it...).

Ideally though, I think all Julia values in literals (FunSQL.Lit(...)) should be converted to SQL parameters/placeholders, so that they use proper serialization from corresponding DB backends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants