Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Nugget #353

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Integration Nugget #353

merged 4 commits into from
Oct 20, 2023

Conversation

mparno
Copy link
Contributor

@mparno mparno commented Oct 20, 2023

Sometimes, maps can be more robust by forcing them to have a nonzero minimum slope. This PR enables this by adding a nugget option to the Monotone Integrand class. The new form of map component $T_d(x_{1:d})$ now has an additional fixed parameter $\epsilon\geq 0$ and takes the form

$$ T_d(x_d; x_{1:d-1}) = f(x_{1:d-1},0) + \int_0^{x_d} \quad g(\partial_d f(x_{1:d},t)) + \epsilon \quad dt $$

The value of $\epsilon$ is set in MonotoneComponent construct but is also available in MapOptions. All of the language bindings have been updated to include a nugget option.

@mparno mparno requested a review from dannys4 October 20, 2023 14:18
@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Test Results

         1 files  ±  0           1 suites  ±0   8s ⏱️ ±0s
     274 tests +  5       274 ✔️ +  5  0 💤 ±0  0 ±0 
36 676 runs  +14  36 676 ✔️ +14  0 💤 ±0  0 ±0 

Results for commit 772de3d. ± Comparison against base commit 3b3b6c5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Test Results with Bindings

59 tests  ±0   59 ✔️ ±0   49s ⏱️ +23s
  2 suites ±0     0 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 772de3d. ± Comparison against base commit 3b3b6c5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Test Results with Externally Built Libraries

         1 files  ±  0           1 suites  ±0   9s ⏱️ -1s
     274 tests +  5       274 ✔️ +  5  0 💤 ±0  0 ±0 
36 676 runs  +14  36 676 ✔️ +14  0 💤 ±0  0 ±0 

Results for commit 772de3d. ± Comparison against base commit 3b3b6c5.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@dannys4 dannys4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Would you mind putting an issue up on MParT.jl asking to include this in the MapOptions binding? I can take care of it from the Julia end.

@mparno
Copy link
Contributor Author

mparno commented Oct 20, 2023

MParT.jl issue #16 created.

@mparno mparno merged commit 46e1d77 into main Oct 20, 2023
@dannys4 dannys4 deleted the mparno/integration-nugget branch October 22, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants