Make generator work for Qt6 #154
Conversation
mrbean-bremen
force-pushed
the
make_generator_work_for_qt6
branch
from
82845cc to
d49384e
Compare
usiems
force-pushed
the
make_generator_work_for_qt6
branch
4 times, most recently
from
72df684 to
2b5c50f
Compare
mrbean-bremen
force-pushed
the
make_generator_work_for_qt6
branch
from
4fc947d to
2ef5c1d
Compare
|
@usiems Just want to say thank you and give some feedback. I just managed to generate the bindings for Qt6.5.3 using the In order to build the library, I needed to manually comment out some code in the generated core and gui builtins but then everything worked - great 👍. Just in case you are interested, here are the changes I needed to do to the generated files to build the library: |
usiems
force-pushed
the
make_generator_work_for_qt6
branch
10 times, most recently
from
f2ca32a to
85e6e15
Compare
This leads me to the conclusion that "constexpr" shouldn't be handled like "const". At least for the purpose of wrapper generation I believe "constexpr" can simply be ignored. "volatile" and "mutable" probably as well, at least when it comes to type equality.
like the un-scoped functions that they really are
(I hope this is the correct place)
it was totally broken, macros were not expanded
(this doesn't change the generated code at this point, but reduces parsing errors)
If this is for a QObject-derived class, they are ignored automatically, but if it is for a Q_GADGET, they obviously are intended for use with scripting
since that better matches the actual behavior
mrbean-bremen
force-pushed
the
make_generator_work_for_qt6
branch
from
aaeb5e7 to
59e19ad
Compare
Since the enum values can be duplicates (they only need to be unique in the scope of the enum class) I opted to prefix them with the enum class name (and an underscore) in the generated wrapper. It would have been nice to use a Python Enum class instead, but after a quick look this seemed to be quite a lot of work.
The resulting enumValueRedirection was not used in the PythonQt generator. Perhaps it was a remnant of the original Java wrapper generator.
obviously copying the object is explicitly prohibited
(in this case assignment operators of QEvent-derived classes in Qt6)
rather re-create enum class as a enum class, and later handle enum classes in PythonQt itself.
usiems
force-pushed
the
make_generator_work_for_qt6
branch
from
59e19ad to
84976a0
Compare
|
So, the generator is in pretty good shape for Qt 6.5 and 6.6 now. For Qt 6.6 QRunnable and QThreadPool are missing (compared to 6.5), but these were not reasonably usable from Python anyway. There are still some open issues I would like to do, like handling of QAnyStringView/QByteArrayView parameters, treating Q_PROPERTIES of gadgets as properties, or putting enum class values in their own enum scope, but those will be done in separate issues. |
These is my work on making the PythonQt_generator work with Qt6 (I worked with the header files of Qt6.5.1).
I believe there is still room for improvement - there are still a lot of parser errors, - but the generated code looks sensible to me. I didn't try to compile it yet, though.