Repository navigation
[fix] exact string-based rounding for long numerals - #125
Open
nikosavola wants to merge 1 commit into
Open
nikosavola wants to merge 1 commit into
nikosavola wants to merge 1 commit into
Conversation
nikosavola
commented
Oct 9, 2026
nikosavola
commented
- round-integer no longer round-trips through float, so long or high-precision numerals are rounded exactly instead of being corrupted or left unrounded
- all rounding modes and tie rules behave as before for short numbers
- regression tests for 17+-digit values
- round-integer no longer round-trips through float, so long or high-precision numerals are rounded exactly instead of being corrupted or left unrounded - all rounding modes and tie rules behave as before for short numbers - regression tests for 17+-digit values
Owner
|
Thanks! Did you make a performance comparison? I am concerned that the function call and while loop could hurt performance when rounding many numbers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.