[mbedtls] Remove support for secp192[k|r]1 curves (part 2) #10522
+27
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some analysis search it was determined that previous test data seem not to belong to the "framework/data_files" certificate files. Therefore new test data has been generated from scratch. The improvement compared to the previous situation is that comments has been added on top of each test in order to explain how to recreate new test data. Signed-off-by: Valerio Setti <[email protected]>
valeriosetti
added
needs-ci
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
4 tasks
valeriosetti
changed the title
3 tasks
valeriosetti
force-pushed
the
issue568-mbedtls-part2
branch
from
388bdd5 to
3e5d471
Compare
Contributor
Author
|
I had to add a new commit updating tf-psa-crypto to make CI happy ( |
valeriosetti
force-pushed
the
issue568-mbedtls-part2
branch
2 times, most recently
from
0ea3ce4 to
be178b5
Compare
valeriosetti
removed
the
needs-preceding-pr
valeriosetti
force-pushed
the
issue568-mbedtls-part2
branch
from
be178b5 to
97b03b1
Compare
… secp256 This replacement is either: - "server5-rsa-signed.crt": if a generic secp256r1 EC key is enough, i.e. any EC key is fine as it's not secp192 since this support is being removed from TF-PSA-Crypto. - "server11-rsa-signed.crt": if an EC key which does not belong to "suite-b" is required. For this case "secp256r1" wouldn't be good, so we use a "secp256k1" key. Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
valeriosetti
force-pushed
the
issue568-mbedtls-part2
branch
from
97b03b1 to
d36ed4a
Compare
valeriosetti
removed
the
needs-reviewer
davidhorstmann-arm
approved these changes
Dec 3, 2025
Contributor
davidhorstmann-arm
left a comment
davidhorstmann-arm
left a comment
There was a problem hiding this comment.
LGTM, thanks!
A special thanks for documenting how you generated everything so well!
github-project-automation
bot
moved this from In Development
to Has Approval
in Roadmap pull requests (new board)
davidhorstmann-arm
added
approved
davidhorstmann-arm
removed this pull request from the merge queue due to a manual request
Contributor
|
Note for posterity that this PR does not depend on Mbed-TLS/TF-PSA-Crypto#570 (instead this PR depends on that one). The update to As a result it's fine to merge. |
github-project-automation
bot
moved this from Has Approval
to Done
in Roadmap pull requests (new board)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a prerequisite for Mbed-TLS/TF-PSA-Crypto#570
It depends on Mbed-TLS/mbedtls-framework#242
PR checklist