This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
feat(server): bub-mdt compatibility #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Lion, Thanks for your contribution, however when lookign through the source code for bub mdt I noticed that the event you've integrated doesn't seem to be the recommended method to create calls, it rather gets scripts to create calls using a server export. |
Maximus7474
reviewed
Dec 30, 2024
Maximus7474
reviewed
Dec 30, 2024
Maximus7474
suggested changes
Dec 30, 2024
|
I'll let you resolve the last comment and update the README and it should be good to merge. |
|
I’ve made the necessary changes and updated the README as requested. |
Maximus7474
approved these changes
Dec 31, 2024
|
All good, everyone has to learn one way or another ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Added support for bub-mdt dispatch. (Not tested in-game)
Major Changes
Modifications done: