Rpc client u subscription #13

MaximilianToe · 2025-05-28T17:45:18Z

No description provided.

github-actions · 2025-05-28T17:47:35Z

Code coverage report is ready! 📈

Code Coverage Percentage: 89.00%
Code Coverage Report: View Coverage Report

github-actions · 2025-05-28T19:59:12Z

Code coverage report is ready! 📈

Code Coverage Percentage: 89.00%
Code Coverage Report: View Coverage Report

github-actions · 2025-05-29T12:02:57Z

Code coverage report is ready! 📈

Code Coverage Percentage: 89.60%
Code Coverage Report: View Coverage Report

github-actions · 2025-05-29T12:30:50Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.80%
Code Coverage Report: View Coverage Report

github-actions · 2025-05-29T20:14:38Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.80%
Code Coverage Report: View Coverage Report

github-actions · 2025-05-30T12:54:37Z

Code coverage report is ready! 📈

Code Coverage Percentage: 91.00%
Code Coverage Report: View Coverage Report

lammjo

Only a very superficial review, but please go ahead and create a PR to upstream if you feel comfortable.

lammjo · 2025-06-03T07:23:46Z

CMakeLists.txt

 file(GLOB_RECURSE SRC_FILES "${CMAKE_CURRENT_SOURCE_DIR}/src/*.cpp")

-add_library(${PROJECT_NAME} ${SRC_FILES})
+add_library(${PROJECT_NAME} ${SRC_FILES}
+		src/client/usubscription/v3/RpcClientUSubscription.cpp
+		include/up-cpp/client/usubscription/v3/RpcClientUSubscription.h
+		include/up-cpp/client/usubscription/v3/USubscription.h
+)


This construction seems odd. Why include only these particular headers and not others? Why include the headers at all? Shouldn't the source file already be picked up by the glob above?

lammjo · 2025-06-03T07:26:55Z

include/up-cpp/client/usubscription/v3/RequestBuilder.h

+	///
+	/// @param topic The `v1::UUri` representing the topic to fetch.
+	///
+	/// @return An `FetchSubscriptionsRequest` configured for the specified


Suggested change

/// @return An `FetchSubscriptionsRequest` configured for the specified

/// @return A `FetchSubscriptionsRequest` configured for the specified

lammjo · 2025-06-03T07:27:26Z

include/up-cpp/client/usubscription/v3/RequestBuilder.h

+	static FetchSubscriptionsRequest buildFetchSubscriptionsRequest(
+	    const v1::UUri& topic);
+
+	/// @brief Build fetch subscritions request for a given subscriber.


Suggested change

/// @brief Build fetch subscritions request for a given subscriber.

/// @brief Build fetch subscriptions request for a given subscriber.

lammjo · 2025-06-03T07:28:05Z

include/up-cpp/client/usubscription/v3/RequestBuilder.h

+	/// @return An `UnsubscribeRequest` configured for the specified topic.
+	static UnsubscribeRequest buildUnsubscribeRequest(const v1::UUri& topic);
+
+	/// @brief Build fetch subscritions request for a given topic.


Suggested change

/// @brief Build fetch subscritions request for a given topic.

/// @brief Build fetch subscriptions request for a given topic.

lammjo · 2025-06-03T07:28:53Z

include/up-cpp/client/usubscription/v3/RequestBuilder.h

+	/// @param subscriber The `SubscriberInfo` representing the subscriber to
+	/// fetch.
+	///
+	/// @return An `FetchSubscriptionsRequest` configured for the specified


Suggested change

/// @return An `FetchSubscriptionsRequest` configured for the specified

/// @return A `FetchSubscriptionsRequest` configured for the specified

lammjo · 2025-06-03T07:29:01Z

include/up-cpp/client/usubscription/v3/RequestBuilder.h

+	///
+	/// @param topic The `v1::UUri` representing the topic to fetch.
+	///
+	/// @return An `FetchSubscribersRequest` configured for the specified topic.


Suggested change

/// @return An `FetchSubscribersRequest` configured for the specified topic.

/// @return A `FetchSubscribersRequest` configured for the specified topic.

lammjo · 2025-06-03T07:29:10Z

include/up-cpp/client/usubscription/v3/RequestBuilder.h

+	/// @param topic The `v1::UUri` representing the topic to (un)register
+	/// for/from.
+	///
+	/// @return An `NotificationsRequest` configured for the specified topic.


Suggested change

/// @return An `NotificationsRequest` configured for the specified topic.

/// @return A `NotificationsRequest` configured for the specified topic.

lammjo · 2025-06-03T07:30:08Z

include/up-cpp/client/usubscription/v3/RpcClientUSubscription.h

+
+}  // namespace uprotocol::core::usubscription::v3
+
+#endif  // UP_CPP_CLIENT_USUBSCRIPTION_V3_RPCCLIENTUSUBSCRIPTION_H


Please add newline

lammjo · 2025-06-03T07:31:29Z

src/client/usubscription/v3/USubscriptionUUriBuilder.cpp

+	return uri;
+}
+
+}  // namespace uprotocol::core::usubscription::v3


Add newline please

github-actions · 2025-06-07T14:41:20Z

Code coverage report is ready! 📈

Code Coverage Percentage: 91.00%
Code Coverage Report: View Coverage Report

github-actions · 2025-06-07T14:44:45Z

Code coverage report is ready! 📈

Code Coverage Percentage: 91.00%
Code Coverage Report: View Coverage Report

github-actions · 2025-06-07T15:06:07Z

Code coverage report is ready! 📈

Code Coverage Percentage: 91.00%
Code Coverage Report: View Coverage Report

github-actions · 2025-06-07T15:10:32Z

Code coverage report is ready! 📈

Code Coverage Percentage: 91.00%
Code Coverage Report: View Coverage Report

github-actions · 2025-06-07T15:12:01Z

Code coverage report is ready! 📈

Code Coverage Percentage: 91.00%
Code Coverage Report: View Coverage Report

github-actions · 2025-06-07T15:15:27Z

Code coverage report is ready! 📈

Code Coverage Percentage: 91.00%
Code Coverage Report: View Coverage Report

github-actions · 2025-06-09T08:05:07Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.30%
Code Coverage Report: View Coverage Report

github-actions · 2025-06-09T09:21:32Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.60%
Code Coverage Report: View Coverage Report

github-actions · 2025-06-09T09:33:32Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.60%
Code Coverage Report: View Coverage Report

github-actions · 2025-06-09T09:36:03Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.60%
Code Coverage Report: View Coverage Report

github-actions · 2025-06-09T09:54:19Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.60%
Code Coverage Report: View Coverage Report

github-actions · 2025-06-09T10:37:41Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.60%
Code Coverage Report: View Coverage Report

github-actions · 2025-06-30T17:32:16Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.50%
Code Coverage Report: View Coverage Report

github-actions · 2025-08-11T18:50:56Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.50%
Code Coverage Report: View Coverage Report

github-actions · 2025-08-11T19:47:27Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.50%
Code Coverage Report: View Coverage Report

github-actions · 2025-08-24T16:31:54Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.50%
Code Coverage Report: View Coverage Report

github-actions · 2025-08-24T16:40:53Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.50%
Code Coverage Report: View Coverage Report

github-actions · 2025-08-24T16:48:59Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.50%
Code Coverage Report: View Coverage Report

github-actions · 2025-08-24T17:27:19Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.60%
Code Coverage Report: View Coverage Report

github-actions · 2025-08-24T17:49:23Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.60%
Code Coverage Report: View Coverage Report

github-actions · 2025-08-24T18:03:07Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.60%
Code Coverage Report: View Coverage Report

github-actions · 2025-08-24T19:04:57Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.60%
Code Coverage Report: View Coverage Report

# Conflicts: # include/up-cpp/communication/RpcClient.h

github-actions · 2025-08-24T19:09:13Z

Code coverage report is ready! 📈

Code Coverage Percentage: 90.60%
Code Coverage Report: View Coverage Report

lammjo reviewed Jun 3, 2025

View reviewed changes

MaximilianToe force-pushed the RpcClientUSubscription branch from 7801d70 to 796a5b1 Compare June 7, 2025 15:03

MaximilianToe force-pushed the RpcClientUSubscription branch from d80a943 to fb81873 Compare June 7, 2025 15:13

MaximilianToe force-pushed the RpcClientUSubscription branch from ede937e to bf9d68e Compare June 9, 2025 09:19

MaximilianToe force-pushed the RpcClientUSubscription branch from bf9d68e to 563924e Compare June 9, 2025 09:31

MaximilianToe force-pushed the RpcClientUSubscription branch from 563924e to 798696b Compare June 9, 2025 09:33

MaximilianToe force-pushed the RpcClientUSubscription branch from 798696b to 303636e Compare June 9, 2025 09:51

MaximilianToe force-pushed the RpcClientUSubscription branch from 303636e to 47973ea Compare June 9, 2025 10:34

MaximilianToe force-pushed the RpcClientUSubscription branch from 701bfdf to 6aae8ea Compare August 11, 2025 19:45

MaximilianToe force-pushed the RpcClientUSubscription branch from 2d22bb9 to 3b8a7ca Compare August 24, 2025 16:37

MaximilianToe force-pushed the RpcClientUSubscription branch from 3b8a7ca to 4375d15 Compare August 24, 2025 16:45

MaximilianToe force-pushed the RpcClientUSubscription branch from ccb349b to 15e8bcb Compare August 24, 2025 17:44

MaximilianToe force-pushed the RpcClientUSubscription branch from 15e8bcb to 0c41572 Compare August 24, 2025 17:59

MaximilianToe force-pushed the RpcClientUSubscription branch from 0c41572 to c8fdce4 Compare August 24, 2025 19:01

MaximilianToe added 8 commits August 24, 2025 21:05

first implementation of usubscription

b557c55

Added test and refactored some parts of usubscription

7354136

# Conflicts: # include/up-cpp/communication/RpcClient.h

made USubscription async with InvokeProtoFuture return type

2bd40b1

implemented cr comments

19fcfd1

rebase and use method in subscription calls

17ef0cf

renamed invokeProtoMethod

f665f7d

added local copies of builder in invokeMethod for thread safety

ce56279

new overloads for build method of UMessageBuilder to avoid copy

f899ee8

MaximilianToe force-pushed the RpcClientUSubscription branch from c8fdce4 to f899ee8 Compare August 24, 2025 19:05

	/// @return An `FetchSubscriptionsRequest` configured for the specified
	/// @return A `FetchSubscriptionsRequest` configured for the specified

	/// @brief Build fetch subscritions request for a given subscriber.
	/// @brief Build fetch subscriptions request for a given subscriber.

	/// @return An `FetchSubscribersRequest` configured for the specified topic.
	/// @return A `FetchSubscribersRequest` configured for the specified topic.

	/// @return An `NotificationsRequest` configured for the specified topic.
	/// @return A `NotificationsRequest` configured for the specified topic.


		} // namespace uprotocol::core::usubscription::v3

		#endif // UP_CPP_CLIENT_USUBSCRIPTION_V3_RPCCLIENTUSUBSCRIPTION_H

Rpc client u subscription #13

Are you sure you want to change the base?

Rpc client u subscription #13

Uh oh!

Conversation

MaximilianToe commented May 28, 2025

Uh oh!

github-actions bot commented May 28, 2025

Uh oh!

github-actions bot commented May 28, 2025

Uh oh!

github-actions bot commented May 29, 2025

Uh oh!

github-actions bot commented May 29, 2025

Uh oh!

github-actions bot commented May 29, 2025

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

lammjo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 7, 2025

Uh oh!

github-actions bot commented Jun 7, 2025

Uh oh!

github-actions bot commented Jun 7, 2025

Uh oh!

github-actions bot commented Jun 7, 2025

Uh oh!

github-actions bot commented Jun 7, 2025

Uh oh!

github-actions bot commented Jun 7, 2025

Uh oh!

github-actions bot commented Jun 9, 2025

Uh oh!

github-actions bot commented Jun 9, 2025

Uh oh!

github-actions bot commented Jun 9, 2025

Uh oh!

github-actions bot commented Jun 9, 2025

Uh oh!

github-actions bot commented Jun 9, 2025

Uh oh!

github-actions bot commented Jun 9, 2025

Uh oh!

github-actions bot commented Jun 30, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 24, 2025

Uh oh!

github-actions bot commented Aug 24, 2025

Uh oh!

github-actions bot commented Aug 24, 2025

Uh oh!

github-actions bot commented Aug 24, 2025

Uh oh!

github-actions bot commented Aug 24, 2025

Uh oh!