Skip to content

feat: introduce EventAll and EventDefault #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

CMCDragonkai
Copy link
Member

Description

I found that it's necessary to have a fall through event handler as well.

So I separated out the EventAny into EventDefault and EventAll.

Now you cannot do addEventListener(f), you have to specify:

addEventListener(EventDefault.name, f);
addEventListener(EventAll.name, f);

2 additional examples of encapsulated pattern and injected pattern was created as per the guidelines here: MatrixAI/js-quic#53 (comment)

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CMCDragonkai
Copy link
Member Author

This is a breaking change, so will go to 3.0.0. @tegefaulkes

@ghost
Copy link

ghost commented Aug 31, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant