Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM Migration #68

Merged
merged 8 commits into from
Mar 20, 2025
Merged

ESM Migration #68

merged 8 commits into from
Mar 20, 2025

Conversation

CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented Aug 14, 2023

Description

Migrate the DB to support ESM

Issues Fixed

Tasks

  • 1. Replace all require calls with await import or something else
  • 2. It seems the idea of dynamically calling require('db') is over
  • 3. Rework the workers based on changes in js-workers feat: migrate to ESM js-workers#12

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@ghost
Copy link

ghost commented Aug 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@tegefaulkes
Copy link
Contributor

I'm taking over this PR as part of the general ESM migration work.

@tegefaulkes tegefaulkes self-assigned this Mar 14, 2025
@tegefaulkes tegefaulkes marked this pull request as draft March 14, 2025 01:25
@tegefaulkes tegefaulkes force-pushed the feature-esm-migrate branch from 1e760ec to 44ad2b1 Compare March 14, 2025 01:30
@tegefaulkes
Copy link
Contributor

Rebased on staging.

@tegefaulkes
Copy link
Contributor

Things have been fixed up and should be working. There is just a small issue with gyp build not working. Could be due to updating the version of node. Just something to look into.

@CMCDragonkai
Copy link
Member Author

Task 3.?

@tegefaulkes
Copy link
Contributor

That's done, just need to get building working. I'm sidetracked with other things right now.

Copy link

linear bot commented Mar 19, 2025

ENG-552

@tegefaulkes tegefaulkes marked this pull request as ready for review March 20, 2025 02:38
@CMCDragonkai
Copy link
Member Author

Note that npm release of this is bundling cross compiled shared objects, unlike js-quic.

@tegefaulkes tegefaulkes force-pushed the feature-esm-migrate branch from 10e9d6a to 11f1ba6 Compare March 20, 2025 07:38
@tegefaulkes tegefaulkes merged commit 3d9522f into staging Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants