Repository navigation
Benchmark workflow: keep pytest below 9.2 - #2072
Merged
Merged
Conversation
pytest 9.2.0 (2026-10-27) breaks pytest-benchmark 5.3.0, the latest release: every benchmark errors with "'Function' object has no attribute '_nodeid'" (ionelmc/pytest-benchmark#321). Since then the benchmark job fails on every pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
LGTM |
Contributor
|
@tombouctou: BTW, it seems that d25e5c0 #2018 produced a very noticable boost in performance, according to several of the benchmarks: 
Thanks for noticing it, and for all your work! |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since pytest 9.2.0 came out (2026-10-27), the "Run performance benchmarks" job fails on every pull request, including #1989, #2032, #2069 and #2070. All 73 benchmarks error at setup:
pytest-benchmark 5.3.0, its latest release, uses a private attribute that pytest 9.2 removed: ionelmc/pytest-benchmark#321, still open. The last passing run (master, 2026-10-27 10:20) had pytest 9.1.1; the failing ones have 9.2.0. pytest-benchmark is 5.3.0 in both.
This keeps pytest below 9.2 in the benchmark workflow, with a comment pointing at the upstream issue, so the pin can go once pytest-benchmark is fixed.
pyproject.tomldoes not pin pytest, so the laterpip install -e .[dev,full]keeps 9.1.x.Checked with a one-test benchmark: pytest 9.2.0 + pytest-benchmark 5.3.0 gives the same error, and pytest 9.1.1 + pytest-benchmark 5.3.0 passes.
🤖 Generated with Claude Code