Handle patterns of the form H[a_Type,a_Type,...] - #1905
Merged
Conversation
rocky
reviewed
Aug 24, 2026
|
|
||
|
|
||
| # --------------------------------------------------------------------------- | ||
| # 7. get_match_candidates() vs get_match_candidates_count() |
Member
There was a problem hiding this comment.
- Smells like AI.
Probably should remove the 7. Since I am not seeing 1. to 6.. I see them now. Not complaining, but noting.
Contributor
Author
There was a problem hiding this comment.
Indeed, I am trying to use IA (Claude Sonnet) to detect what is going wrong with this module. Most of the tests and benchmarks it suggested sound reasonable to me, so I included them.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles another corner case of patterns with typed elements. Now, more tests pass.