Simplify/generalize Sympy expression to Sympy predicate - #1904
Merged
Conversation
Now handles Or, Not and swapped relational expressions to_sympy() function added for Element. All System Symbols are now marked Final. A couple more tests added. (But many more are needed).
Member
Author
|
(There will be a couple more iterations of this.) |
mmatera
reviewed
Aug 24, 2026
| """ | ||
| from typing import TYPE_CHECKING, Dict, List, Optional, Sequence, Tuple, Union, cast | ||
|
|
||
| from typing import ( |
Contributor
There was a problem hiding this comment.
This starts to be quite large. Maybe in another round, we should split this into submodules.
Member
Author
|
In the next round, I will split out the SymPy predicate code. And probably more tests. In the round after that, maybe we'll be able to get to Assume! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now handles Or, Not and swapped relational expressions
to_sympy() function added for Element.
All System Symbols are now marked Final.
A couple more tests added. (But many more are needed).