SS-321 Migrate Kafka Source/Sink TOPIC METADATA REFRESH INTERVAL#37349
Open
patrickwwbutler wants to merge 3 commits into
Open
SS-321 Migrate Kafka Source/Sink TOPIC METADATA REFRESH INTERVAL#37349patrickwwbutler wants to merge 3 commits into
patrickwwbutler wants to merge 3 commits into
Conversation
martykulma
reviewed
Jun 29, 2026
| if matches!( | ||
| option.name, | ||
| KafkaSourceConfigOptionName::TopicMetadataRefreshInterval | ||
| ) && let Some(WithOptionValue::Value(Value::String(ref mut s))) = |
Contributor
There was a problem hiding this comment.
I think TopicMetadataRefreshInterval can also be Value::Number (TOPIC METADATA REFRESH INTERVAL = 0.5) and Value::Interval (TOPIC METADATA REFRESH INTERVAL = INTERVAL '0.5s')
Ultimately, its rust type is Duration in src/sql/src/kafka_util.rs, but I think that gets parsed out using TryFromValue in with_options.rs - which parses it as an interval.
Contributor
There was a problem hiding this comment.
Correct, QA LLM review flagged the same thing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/materializeinc/issue/SS-321/create-migration-for-kafka-sands-objects-refresh-interval
This PR (once again) makes any values <1s invalid for this option, but this could make some existing sources/sinks have invalid SQL, so the ASTs need to be migrated on upgrades.
Adds a platform checks test to check that migration on upgrade functions properly.