SS-320 add nonzero duration constraint to some sysvars#37344
Open
patrickwwbutler wants to merge 1 commit into
Open
SS-320 add nonzero duration constraint to some sysvars#37344patrickwwbutler wants to merge 1 commit into
patrickwwbutler wants to merge 1 commit into
Conversation
def-
reviewed
Jun 30, 2026
def-
left a comment
def-
left a comment
Contributor
There was a problem hiding this comment.
For most of these parameters you could have set them to 0 system-wide, and it would be ok as long as you don't use that feature. So it's possible a customer has accidentally set them to 0. Now with this change their system would crash-loop during the upgrade, which isn't great probably.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/materializeinc/issue/SS-320/alter-system-set-storage-statistics-interval-0s-causes-panic-thread
and also adds the constraint to a few more interval system variables