mz-debug: Find active generation services #33886
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mz_instance_name: &String, | ||
| ) -> Result<Vec<ServiceInfo>> { | ||
| // Get the Materialize CR to extract the active generation | ||
| let mz_cr = get_materialize_cr(client, k8s_namespace, mz_instance_name).await?; |
There was a problem hiding this comment.
Nitpick, it would be nicer to just get this once, rather than in each function that needs it. Not a big deal, though.
| })?; | ||
|
|
||
| // Filter by active generation - only include services whose owner StatefulSet | ||
| // has metadata.generation matching the Materialize CR's active_generation |
There was a problem hiding this comment.
Suggested change
| // has metadata.generation matching the Materialize CR's active_generation | |
| // has materialize.cloud/generation matching the Materialize CR's active_generation |
Kubernetes also has a concept of generation and it means something else.
Comment on lines
219
to
258
| let cluster_services: Vec<ServiceInfo> = services | ||
| .iter() | ||
| .filter_map(|service| { | ||
| let name = service.metadata.name.clone()?; | ||
| let spec = service.spec.clone()?; | ||
| let selector = spec.selector?; | ||
| let ports = spec.ports?; | ||
|
|
||
| // Check if this is a cluster service | ||
| if selector.get("environmentd.materialize.cloud/namespace")? != "cluster" { | ||
| return None; | ||
| } | ||
|
|
||
| // Check if the owner reference points to environmentd StatefulSet in the same mz instance | ||
| // Check if the owner reference points to an environmentd StatefulSet | ||
| let envd_statefulset_reference_name = service | ||
| .metadata | ||
| .owner_references | ||
| .as_ref()? | ||
| .iter() | ||
| // There should only be one StatefulSet reference to environmentd | ||
| // There should only be one StatefulSet reference to environmentd | ||
| .find(|owner_reference| owner_reference.kind == "StatefulSet")? | ||
| .name | ||
| .clone(); | ||
|
|
||
| if !statefulsets | ||
| .iter() | ||
| .filter_map(|statefulset| statefulset.metadata.name.clone()) | ||
| .any(|name| name == envd_statefulset_reference_name) | ||
| { | ||
| // Find the StatefulSet that owns this service and check if it matches the active generation | ||
| let matching_statefulset = statefulsets.iter().find(|statefulset| { | ||
| statefulset.metadata.name.as_ref() == Some(&envd_statefulset_reference_name) | ||
| })?; | ||
|
|
||
| // Filter by active generation - only include services whose owner StatefulSet | ||
| // has metadata.generation matching the Materialize CR's active_generation | ||
| let statefulset_generation = matching_statefulset | ||
| .metadata | ||
| .annotations | ||
| .as_ref()? | ||
| .get("materialize.cloud/generation")? | ||
| .parse::<i64>() | ||
| .ok()?; | ||
| let active_generation_i64 = i64::try_from(active_generation).ok()?; | ||
| if statefulset_generation != active_generation_i64 { |
There was a problem hiding this comment.
Shouldn't we just do the following?
- Determine the environmentd statefulset name.
- Iterate through all services, filtering on if they are owned by the environmentd statefulset.
We shouldn't need to do any other filtering, since the environmentd statefulset is per-generation and doesn't own any objects of other generations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.