Skip to content

ore/netio: support splitting streams into tx/rx halves #32515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

teskje
Copy link
Contributor

@teskje teskje commented May 16, 2025

This PR adds support for splitting mz_ore::netio::Stream into a read and a write half, so reading from and writing to a connection can be done independently.

Split out of the work that adds the new cluster transport protocol (#32330).

Motivation

  • This PR adds a known-desirable feature.

Part of https://github.com/MaterializeInc/database-issues/issues/5038

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@teskje teskje mentioned this pull request May 16, 2025
5 tasks
@teskje teskje marked this pull request as ready for review May 16, 2025 16:31
@teskje teskje requested a review from antiguru May 21, 2025 02:41
@teskje
Copy link
Contributor Author

teskje commented May 21, 2025

TFTR!

@teskje teskje merged commit 7eb443a into MaterializeInc:main May 21, 2025
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants