Skip to content

Add OptimizationBegan query lifecycle event #32508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ggevay
Copy link
Contributor

@ggevay ggevay commented May 15, 2025

Adds the OptimizationBegan event to the query lifecycle, as mentioned in the Lifecycle design doc.

Note that this should be very close in time to ExecutionBegan if things are behaving correctly. However, I have reason to believe that this is not always the case: Some time ago, the OptimizationFinished event used to have a bug where it was actually showing what the new OptimizationBegan event will be showing, and looking at a certain user's lifecycle history from before fixing the bug, there were sometimes multiple seconds between ExecutionBegan and the buggy OptimizationFinished.

After this PR is rolled out to users, we should check whether it is still happening that the beginning of optimization is sometimes far from ExecutionBegan, and if yes, then debug.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ggevay ggevay added the A-ADAPTER Topics related to the ADAPTER layer label May 15, 2025
@ggevay ggevay marked this pull request as ready for review May 15, 2025 19:35
@ggevay ggevay requested a review from a team as a code owner May 15, 2025 19:35
@ggevay ggevay requested a review from aljoscha May 15, 2025 19:35
@ggevay
Copy link
Contributor Author

ggevay commented May 16, 2025

Moving back to draft, as people are concerned about the scalability of the lifecycle builtin tables.

@ggevay ggevay marked this pull request as draft May 16, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ADAPTER Topics related to the ADAPTER layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant