Add OptimizationBegan
query lifecycle event
#32508
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
OptimizationBegan
event to the query lifecycle, as mentioned in the Lifecycle design doc.Note that this should be very close in time to
ExecutionBegan
if things are behaving correctly. However, I have reason to believe that this is not always the case: Some time ago, theOptimizationFinished
event used to have a bug where it was actually showing what the newOptimizationBegan
event will be showing, and looking at a certain user's lifecycle history from before fixing the bug, there were sometimes multiple seconds betweenExecutionBegan
and the buggyOptimizationFinished
.After this PR is rolled out to users, we should check whether it is still happening that the beginning of optimization is sometimes far from
ExecutionBegan
, and if yes, then debug.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.