Skip to content

ci: disable builtin continual tasks #32506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

teskje
Copy link
Contributor

@teskje teskje commented May 15, 2025

This PR disables the builtin continual tasks in CI.

Context in Slack.

Motivation

  • This PR adjusts a CI config.

The motivation is twofold:

  • We are not enabling builtin CTs anywhere else by default (prod, staging, local dev) and nobody is currently driving the feature forward. Disabling the builtin CTs in CI makes our CI config more similar to what we run in production.
  • We don't have migration implemented for builtin CTs, and the lack of migration support blocks PRs that want to change builtin sources that have CTs built on them (such as controller: emit undefined lag for unreadable collections #32329).

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@teskje
Copy link
Contributor Author

teskje commented May 15, 2025

I've left a note about the lack of migration support for CTs in the CT epic, in case we'll pick this up again at some point.

@teskje teskje force-pushed the ci-disable-builtin-cts branch 2 times, most recently from d7ca0be to 83fbd2a Compare May 15, 2025 16:20
@teskje teskje marked this pull request as ready for review May 15, 2025 16:20
@teskje teskje requested a review from a team as a code owner May 15, 2025 16:20
@teskje teskje requested a review from def- May 15, 2025 16:20
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nightly triggered: https://buildkite.com/materialize/nightly/builds/12090 Edit: Lgtm, or at least unrelated to this PR

Copy link
Contributor

@bkirwi bkirwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@teskje teskje force-pushed the ci-disable-builtin-cts branch from 83fbd2a to eee1a52 Compare May 21, 2025 14:04
@teskje
Copy link
Contributor Author

teskje commented May 22, 2025

TFTRs!

@teskje teskje merged commit 6d18879 into MaterializeInc:main May 22, 2025
271 checks passed
@teskje teskje deleted the ci-disable-builtin-cts branch May 22, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants