Skip to content

ci: Add ASan build in nightly and fix sanitizer agent scaling #32505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
Merged

ci: Add ASan build in nightly and fix sanitizer agent scaling #32505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e749114
ci: Add ASan build in nightly
def- May 15, 2025
ebadd33
ci: Fix sanitizer agent scaling
def- May 15, 2025
4df5ee3
prevent xlang LTO when a sanitizer is enabled
ParkMyCar May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ci/mkpipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,18 +180,20 @@ def visit(step: dict[str, Any]) -> None:
agent = "hetzner-aarch64-4cpu-8gb"
elif agent == "hetzner-aarch64-4cpu-8gb":
agent = "hetzner-aarch64-8cpu-16gb"
elif agent == "hetzner-aarch64-8cpu-16gb":
agent = "hetzner-aarch64-16cpu-32gb"
elif agent == "hetzner-x86-64-2cpu-4gb":
agent = "hetzner-x86-64-4cpu-8gb"
elif agent == "hetzner-x86-64-4cpu-8gb":
agent = "hetzner-x86-64-8cpu-16gb"
elif agent == "hetzner-x86-64-8cpu-16gb":
agent = "hetzner-x86-64-16cpu-32gb"
elif agent == "hetzner-x86-64-16cpu-32gb":
agent = "hetzner-x86-64-16cpu-64gb"
agent = "hetzner-x86-64-dedi-16cpu-64gb"
elif agent == "hetzner-x86-64-16cpu-64gb":
agent = "hetzner-x86-64-32cpu-128gb"
elif agent == "hetzner-x86-64-32cpu-128gb":
agent = "hetzner-x86-64-48cpu-192gb"
agent = "hetzner-x86-64-dedi-32cpu-128gb"
elif agent == "hetzner-x86-64-dedi-32cpu-128gb":
agent = "hetzner-x86-64-dedi-48cpu-192gb"
step["agents"] = {"queue": agent}

if step.get("sanitizer") == "skip":
Expand Down
26 changes: 26 additions & 0 deletions ci/nightly/pipeline.template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,32 @@ steps:
agents:
queue: builder-linux-aarch64-mem

- id: build-x86_64-asan
label: ":bazel: Build x86_64 (ASan)"
command: bin/ci-builder run min bin/pyactivate -m ci.test.build
inputs:
- "*"
artifact_paths: bazel-explain.log
depends_on: []
timeout_in_minutes: 60
agents:
queue: builder-linux-x86_64
env:
CI_SANITIZER: address

- id: build-aarch64-asan
label: ":bazel: Build aarch64 (ASan)"
command: bin/ci-builder run min bin/pyactivate -m ci.test.build
inputs:
- "*"
artifact_paths: bazel-explain.log
depends_on: []
timeout_in_minutes: 60
agents:
queue: builder-linux-aarch64-mem
env:
CI_SANITIZER: address

- group: Linters
key: linters
steps:
Expand Down
2 changes: 2 additions & 0 deletions misc/bazel/platforms/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ selects.config_setting_group(
match_all = [
"@platforms//os:linux",
":use_xlang_lto",
# ASAN doesn't support being built when cross language LTO is enabled.
":sanitizer_none",
],
visibility = ["//visibility:public"],
)
Expand Down