add configurable number of shards to compare_and_set bench #32484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently possible, but a bit odd, to have an exchangeable part that doesn't have a lease attached. This switches us to using the "exchangeable" part directly, instead of inventing and immediately dropping the lease.
The only case where this wasn't true was exchanging over a network, and we no longer use leased part for that.
ptravers
force-pushed
the
9187-cmp-swap-bench
branch
from
bf3748a to
eff4fdf
Compare
Due to an oversight the controller would initialize the state tracked for new compute clusters with the known workload class, but omit doing the same for storage clusters. As a result, metrics and wallclock lag measurements would sometimes miss their `workload_class` annotations after an envd restart.
…reate_list_index_literal Fix types in `reduce_list_create_list_index_literal`
…radiction Don't panic when the same parameter is coerced twice
ParkMyCar
approved these changes
May 14, 2025
At least those that we managed to find by futzing with result ordering as a result of stashed peek responses.
terraform tests: Bump to AWS v0.4.5, GCP v0.4.2, Azure v0.4.2
Bumps the simple2 group with 1 update: [prost-reflect](https://github.com/andrewhickman/prost-reflect). Updates `prost-reflect` from 0.15.2 to 0.15.3 - [Release notes](https://github.com/andrewhickman/prost-reflect/releases) - [Changelog](https://github.com/andrewhickman/prost-reflect/blob/main/CHANGELOG.md) - [Commits](andrewhickman/prost-reflect@prost-reflect-v0.15.2...prost-reflect-v0.15.3) --- updated-dependencies: - dependency-name: prost-reflect dependency-version: 0.15.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: simple2 ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [compact_bytes](https://github.com/ParkMyCar/compact_bytes) from 0.1.4 to 0.2.0. - [Commits](https://github.com/ParkMyCar/compact_bytes/commits/v0.2.0) --- updated-dependencies: - dependency-name: compact_bytes dependency-version: 0.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tempfile](https://github.com/Stebalien/tempfile) from 3.19.1 to 3.20.0. - [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md) - [Commits](Stebalien/tempfile@v3.19.1...v3.20.0) --- updated-dependencies: - dependency-name: tempfile dependency-version: 3.20.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
ci: Bump some agent sizes in release qualification
…t/pip/ci/builder/simple-b9bfd87a38 build(deps): bump the simple group in /ci/builder with 6 updates
…t/cargo/simple2-2ab277ad21 build(deps): bump prost-reflect from 0.15.2 to 0.15.3 in the simple2 group
…t/cargo/compact_bytes-0.2.0 build(deps): bump compact_bytes from 0.1.4 to 0.2.0
…t/cargo/tempfile-3.20.0 build(deps): bump tempfile from 3.19.1 to 3.20.0
Bumps the simple1 group with 4 updates: [differential-dataflow](https://github.com/TimelyDataflow/differential-dataflow), [hyper-util](https://github.com/hyperium/hyper-util), [differential-dogs3](https://github.com/TimelyDataflow/differential-dataflow) and [cc](https://github.com/rust-lang/cc-rs). Updates `differential-dataflow` from 0.15.1 to 0.15.2 - [Release notes](https://github.com/TimelyDataflow/differential-dataflow/releases) - [Changelog](https://github.com/TimelyDataflow/differential-dataflow/blob/master/release-plz.toml) - [Commits](TimelyDataflow/differential-dataflow@differential-dataflow-v0.15.1...differential-dataflow-v0.15.2) Updates `hyper-util` from 0.1.11 to 0.1.12 - [Release notes](https://github.com/hyperium/hyper-util/releases) - [Changelog](https://github.com/hyperium/hyper-util/blob/master/CHANGELOG.md) - [Commits](hyperium/hyper-util@v0.1.11...v0.1.12) Updates `differential-dogs3` from 0.1.12 to 0.1.13 - [Release notes](https://github.com/TimelyDataflow/differential-dataflow/releases) - [Changelog](https://github.com/TimelyDataflow/differential-dataflow/blob/master/release-plz.toml) - [Commits](TimelyDataflow/differential-dataflow@differential-dogs3-v0.1.12...differential-dogs3-v0.1.13) Updates `cc` from 1.2.23 to 1.2.24 - [Release notes](https://github.com/rust-lang/cc-rs/releases) - [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/cc-rs@cc-v1.2.23...cc-v1.2.24) --- updated-dependencies: - dependency-name: differential-dataflow dependency-version: 0.15.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: simple1 - dependency-name: hyper-util dependency-version: 0.1.12 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: simple1 - dependency-name: differential-dogs3 dependency-version: 0.1.13 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: simple1 - dependency-name: cc dependency-version: 1.2.24 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: simple1 ... Signed-off-by: dependabot[bot] <[email protected]>
…t/cargo/simple1-7d6defae42 build(deps): bump the simple1 group with 4 updates
This commit pins the version of the `minio/mc` image to the same version we use for the `Mc` mzcompose service. It's a pretty old version and we should probably upgrade, but leaving that as a follow up.
…version cloudtest: pin mc version
This reverts commit 69e7465.
[persist] Revert "Incremental compaction (MaterializeInc#32381)"
It turns out that calling `sentry_panic::panic_handler` doesn't work because it expects the `PanicIntegration` to be enabled and silently does nothing when that isn't the case. We don't want to enable the panic integration because that would also install Sentry's panic hook. So instead we have to implement the panic handler logic manually.
ore: fix reporting of panics to Sentry
tests: Skip `5_repeat_row_dataflow.slt` and `5_repeat_row_folding.slt`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
we want to test how persist behaves with 2000 shards doing compare_and_set.
request from reviewers of: https://www.notion.so/materialize/High-CPU-Usage-Emulator-1f113f48d37b80c395def016bea16b0d
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.