Skip to content

jemalloc: use GCC intrinsics for unwinding in profiling #32141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Apr 9, 2025

This is a workaround for deadlocks caused by nested unwinding. Alternative to #32139.

Motivation

  • This PR fixes a recognized bug.

Fixes https://github.com/MaterializeInc/database-issues/issues/9159

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def-
Copy link
Contributor

def- commented Apr 9, 2025

We can do a bunch of anyhow! calls to have a quick stress test to see if this prevents the issues. (or revert #32138)

@teskje teskje force-pushed the jemalloc-gcc-intrinsics branch 14 times, most recently from e21f0ba to ef12a7b Compare April 18, 2025 16:58
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore the upgrade test failures in Nightly, they are fixed by #32265

The only thing I'm afraid of here is that we might miss the argument in some C library and then get a crash in production as a consequence of that

@teskje teskje force-pushed the jemalloc-gcc-intrinsics branch from ef12a7b to 50e06ea Compare April 21, 2025 08:27
@teskje
Copy link
Contributor Author

teskje commented Apr 21, 2025

The only thing I'm afraid of here is that we might miss the argument in some C library and then get a crash in production as a consequence of that

Yeah, it's a real risk. Bazel helps us out here a lot by letting us set -fno-omit-frame-pointer as a cflag for all external libraries we build. So the risk is limited to libraries we don't build as part of the Bazel build process. At the moment, the ones I'm aware of are:

Some risk still remains, but I'd hope that CI will flag anything I missed above. It did point out libc++ as a library I missed initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants