Skip to content

Conversation

@ggevay
Copy link
Contributor

@ggevay ggevay commented May 10, 2024

This is an attempt on https://github.com/MaterializeInc/database-issues/issues/1291 as discussed here, at least for the varchar_to_text case.

Draft for now, because I'd like to run a full CI first.

In the meantime, there is a relevant design doc PR from Michael: #27239, where this PR is the eq-type alternative.

Edit: A problem is that the adapter crate also calls MIR's typ in several places, to get RelationDesc's. We'd need to do something about these before merging the PR. A possible solution would be to get the scalar types from the HIR expression instead. This would have sometimes better or worse nullability than MIR's typ, but it being more stable than MIR's typ would probably be an advantage anyway, regardless of this PR.

Motivation

Tips for reviewer

Checklist

@ggevay ggevay added the A-compute Area: compute label May 10, 2024
@ggevay ggevay changed the title Varchar to text join Remove varchar_to_text in MIR May 10, 2024
@ggevay ggevay changed the title Remove varchar_to_text in MIR Remove varchar_to_text from MIR May 10, 2024
@ggevay ggevay force-pushed the varchar_to_text_join branch from c215024 to 1c8af88 Compare February 16, 2025 16:38
@ggevay ggevay force-pushed the varchar_to_text_join branch from 0aeb1d8 to 0831f60 Compare February 17, 2025 15:15
@ggevay ggevay added the A-CLUSTER Topics related to the CLUSTER layer label Feb 17, 2025
@ggevay ggevay force-pushed the varchar_to_text_join branch from 0831f60 to 5157d8e Compare February 18, 2025 12:44
@ggevay ggevay mentioned this pull request Feb 19, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLUSTER Topics related to the CLUSTER layer A-compute Area: compute

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant