Ensure MIR join equivalences include typecheckable non-nullable fields #19263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18666 introduced an MIR typechecker. This PR is meant to address one of its imprecisions.
Join equivalences use raw
Datumequality for inner joins, which would equateNULLs---when we compile a join from SQL we are careful to avoid hitting this case, but it's not 100% clear that we avoid this in all cases.The typechecker has code that emits debug-level traces for when a join equivalence class is all nullable fields. But a number of queries---including some that are part of the startup sequence---generate queries that cause these traces to happen.
Motivation
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.