Skip to content

Revert usage of x:Reference #3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JorisCleVR
Copy link
Contributor

We found out that the earlier change to x:Reference causes System.Xaml.XamlObjectWriterException to occur internally in XAML.

With some further digging we found in the documentation on https://learn.microsoft.com/en-us/dotnet/desktop/xaml-services/xreference-markup-extension?redirectedfrom=MSDN:
x:Reference is a construct defined in XAML 2009. In WPF, you can use XAML 2009 features, but only for XAML that is not WPF markup-compiled. Markup-compiled XAML and the BAML form of XAML do not currently support the XAML 2009 language keywords and features.

Thought the x:Reference at first glance seems to work it creates internal exceptions within XAML, therefore it is probably wise to revert it back.

@Keboo Keboo added this to the 5.3.0 milestone Jul 21, 2025
@Keboo Keboo enabled auto-merge (squash) July 21, 2025 17:29
@JorisCleVR
Copy link
Contributor Author

@Keboo for some reason this PR is not merged because it was unable to find the host when downloading the icon. Was this a temporary glitch of the build server? If so can you restart the merge?
Otherwise please let me know what I could do to get this PR merged.

@Keboo
Copy link
Member

Keboo commented Aug 20, 2025

@JorisCleVR thanks for the ping. I had noticed it but have been busy remodeling my office so haven't had my usual streaming time. Working on a fix to get this in.

@Keboo
Copy link
Member

Keboo commented Aug 20, 2025

@JorisCleVR can you rebase this on latest master. I believe the nuget icon issue is now fixed.

@JorisCleVR
Copy link
Contributor Author

@Keboo Good to know that you noticed it. As long as it is still in the pipeline it is okay for me. For now, good luck with the remodeling your office. A good workspace is also very important :).

auto-merge was automatically disabled August 22, 2025 15:50

Head branch was pushed to by a user without write access

@JorisCleVR JorisCleVR force-pushed the Feature/Revert-usage-of-xReference branch from 0393840 to 938975f Compare August 22, 2025 15:50
@Keboo Keboo enabled auto-merge (squash) August 22, 2025 16:25
@Keboo Keboo merged commit 471110f into MaterialDesignInXAML:master Aug 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants