Repository navigation
fix: back arrow on the first screen of shells and module mounts - #102
Open
Mastersam07 wants to merge 4 commits into
Open
Mastersam07 wants to merge 4 commits into
Mastersam07 wants to merge 4 commits into
Conversation
Contributor
|
📖 Docs preview: https://kaisel.dev/pr-102/ (updates on every push; removed when this PR closes) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #102 +/- ##
==========================================
+ Coverage 99.66% 99.67% +0.01%
==========================================
Files 43 43
Lines 2418 2496 +78
==========================================
+ Hits 2410 2488 +78
Misses 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91
The first screen inside a shell or module mount had no
AppBarback arrow, though system back already left the shell. It now shows one when there's a page below the shell, and tapping it pops the shell. This makes a single branch shell a clean way to share a provider across a group of screens.KaiselModuleMountgive their first page a local history entry, soAppBarshows the arrow and tapping it pops the hosting page.rootBackArrow: falseopts out per shell or module mount.kaisel_shell_root_back_test.dart.