Reduce measure errors #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Martinsos hello? |
|
Hey @JanHBade ! I am pretty slammed recently so don't have much time to review the PRs here, sorry for the delay. Url got modified to point to your repo -> that should be reverted. Finally, I would love to be fully convinced this is the right change. I saw that other PR and mentioning of certain source file but I don't know where to find it -> any way you can point me to it? Also, how confident are you in this change, anythign that could go wrong with it? How mcuh do you understand about it? |
|
made an new one #16 |
|
@JanHBade why new one? And you didn't asnwer my questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From another lib: gamegine/HCSR04-ultrasonic-sensor-lib#3