Update Delta example files #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseivaldo Benito Junior <[email protected]>
|
Uh yeah, these new configs are missing -#define DELTA_DIAGONAL_ROD_2 sq(DELTA_DIAGONAL_ROD) now, and Marlin won't compile since Marlin_main.cpp references that define in three places. |
|
Wow! I may messed up during manual merge. I will redo it ASAP. sorry. (actually my personal delta config is in another branch I merged this just to upgrade... correcting it, sorry again) |
|
As I told I have messed up during up-merge process and lost this parameter. Now correct and pull request #687 sent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've upmerged the Delta example configuration files to somehow match the newer Configuration.h and Configuration_adv.h
Signed-off-by: Joseivaldo Benito Junior [email protected]