Skip to content

MDEV-6589: Remove have_debug_sync requirement#5116

Draft
ParadoxV5 wants to merge 1 commit into
mainfrom
px5.6589-debug-sync
Draft

MDEV-6589: Remove have_debug_sync requirement#5116
ParadoxV5 wants to merge 1 commit into
mainfrom
px5.6589-debug-sync

Conversation

@ParadoxV5
Copy link
Copy Markdown
Contributor

The test for rpl.rpl_parallel_mdev6589 required include/have_debug_sync.inc but did not use @@debug_sync (besides RESETting it during cleanup).
It uses MASTER_GTID_WAIT().

@ParadoxV5 ParadoxV5 requested a review from knielsen May 24, 2026 01:14
@ParadoxV5 ParadoxV5 added MariaDB Corporation Replication Patches involved in replication labels May 24, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the rpl_parallel_mdev6589.test file by removing the have_debug_sync.inc dependency and the associated DEBUG_SYNC reset statements. I have no feedback to provide as there are no review comments.

@ParadoxV5
Copy link
Copy Markdown
Contributor Author

Hm, is there an amended rule that test changes always go to the earliest applicable LTS (10.6 10.11 in this case) – both fixes and refactors?

@ParadoxV5 ParadoxV5 marked this pull request as draft May 24, 2026 18:12
The test for `rpl.rpl_parallel_mdev6589` required
`include/have_debug_sync.inc` but did not use `@@debug_sync`
(besides RESETting it during cleanup). It uses `MASTER_GTID_WAIT()`.
@ParadoxV5 ParadoxV5 force-pushed the px5.6589-debug-sync branch from 185f91d to 90b029f Compare May 24, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MariaDB Corporation Replication Patches involved in replication

Development

Successfully merging this pull request may close these issues.

1 participant