10.11 mdev 33309 no r_other_time_ms shown in analyze format=json output for update or delete queries

[bsrikanth-mariadb]

MDEV-33309: for update|delete analyze format=json doesn't show r_other_time_ms

Single-table UPDATE/DELETEs only show r_total_time_ms in top-level query block.
Replace it with r_table_time_ms and r_other_time_ms.

[spetrunia]

Please add --echo # Top-level query block must have r_table_time_ms and r_other_time_ms

[spetrunia]

Please also add a comment like requested above.

[spetrunia]

MDEV-33309: for update|delete analyze format=json doesn't show r_other_time_ms

Only r_total_time_ms is provided for query_block, in UPDATE|DELETE queries.
This PR replaces it with 2 metrics i.e. r_table_time_ms, and r_other_time_ms.

In commit comments, instead of "This PR does X" it is common to write "Do X"
Please change this comment to something line:

Single-table UPDATE/DELETEs only show r_total_time_ms in top-level query block.
Replace it with r_table_time_ms and r_other_time_ms.

[spetrunia]

I was wondering where does the update time get billed to
Ran

 analyze format=json update t1 set a=a+1 where t1.pk > 994;

and paused it in ha_innobase::update() for a while.
The time got billed to the r_table_time_ms, good:

| {
  "query_optimization": {
    "r_total_time_ms": 0.814298762
  },
  "query_block": {
    "select_id": 1,
    "r_total_time_ms": 20056.984,
    "table": {
      "update": 1,
      "table_name": "t1",
      "access_type": "range",
      "possible_keys": ["PRIMARY"],
      "key": "PRIMARY",
      "key_length": "4",
      "used_key_parts": ["pk"],
      "rows": 6,
      "r_rows": 6,
      "r_filtered": 100,
      "r_table_time_ms": 20056.77929,
      "r_other_time_ms": 0.166702744,
      "r_engine_stats": {
        "pages_accessed": 11,
        "pages_updated": 15
      },
      "attached_condition": "t1.pk > 994"
    }
  }
} |

FK updates will be billed to the r_table_time_ms.
Triggers are run from the SQL layer and so will be billed to r_other_time_ms ...
This is ok, we just need to make a note in the docs.

[spetrunia]

Please address the input above and then the patch is ok.

[bsrikanth-mariadb]

Please address the input above and then the patch is ok.

Sure, addressed the comments.