MDEV-37146 mariadb-dump: Replace SHOW SLAVE STATUS usage with information_schema.SLAVE_STATUS #4284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion_schema.SLAVE_STATUS `SELECT … FROM information_schema.SLAVE_STATUS` is an alternative to `SHOW SLAVE STATUS` that supports `WHERE` and column selection. Utilizing this server-side feature allows `mariadb-dump --dump-slave` to iterate only the required data on the client side.
ParadoxV5
commented
Sep 5, 2025
Comment on lines
7510
to
-7583
| /* Check if the server support multi source */ | ||
| if (mysql_get_server_version(mysql) >= 100000) | ||
| { | ||
| multi_source= 2; | ||
| have_mariadb_gtid= 1; | ||
| } |
There was a problem hiding this comment.
Re: #3780 (comment)
This patch currently drops support for versions that didn’t have multi-source, which are before 10.0.
Is this acceptable because they have long been EOL?
Additionally, to what extent should this program continue to support dumping MySQL?
ParadoxV5
commented
Sep 6, 2025
Comment on lines
+6490
to
+6491
| "SELECT Connection_name, Master_Host, Master_Port," | ||
| "Master_Log_File, Exec_Master_Log_Pos FROM information_schema.SLAVE_STATUS") |
There was a problem hiding this comment.
🧐 the index-9 column… This should be
Suggested change
| "SELECT Connection_name, Master_Host, Master_Port," | |
| "Master_Log_File, Exec_Master_Log_Pos FROM information_schema.SLAVE_STATUS") | |
| "SELECT Connection_name, Master_Host, Master_Port, Relay_Master_Log_File," | |
| "Exec_Master_Log_Pos FROM information_schema.SLAVE_STATUS") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SELECT … FROM information_schema.SLAVE_STATUSis an alternative toSHOW SLAVE STATUSthat supportsWHEREand column selection.Utilizing this server-side feature allows
mariadb-dump --dump-slaveto iterate only the required data on the client side.Release Notes
Optimized
mariadb-dump --dump-slavefor MariaDB 10.0 and above.How can this PR be tested?
Test
mariadb-dump --dump-slaveas usual, e.g., through MTR testsmain.rpl_mysqldump_slave&multi_source.mariadb-dump_slave.Basing the PR against the correct MariaDB version
mainbranch.PR quality check