-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: add support for a callback for activeDayFiller #77
base: main
Are you sure you want to change the base?
[feat]: add support for a callback for activeDayFiller #77
Conversation
|
Looks great! Can you also add a story to test the functionality? |
I actually saw you suggested this should be able at any level on theming, which makes a lot of sense, and I would like to work on that contribution! I'll see if I can work on that over the weekend :). Can you please show me an example of tests for components so I can build test suites for this feature? When I worked on this I wanted to add the test but I couldn't find any component tests. |
@MarceloPrado friendly reminder of the comment above! |
Hey @MarceloPrado, can we move forward with this PR? Would love to include it in my next release! Thank you. |
I wish I could approve this PR! |
@MarceloPrado i see the package has been gaining some popularity lately! If you are interested on supporting this, let me know :) |
hi folks, sorry! I need to improve my GH notifications setup. @isaiasdearcog for testing, I'm currently using storybook - no snapshot testing yet, just a story dedicated to this feature that we can run and explore if things are working. In the future, we could use something like Chromatic to snapshot each story. For the purpose of this PR, it would be good to see a few stories testing the feature. You can attach a video of your simulator going over them |
Addresses this request: #76