Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: add support for a callback for activeDayFiller #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isaiasdearcog
Copy link

Addresses this request: #76

Copy link

changeset-bot bot commented Dec 21, 2024

⚠️ No Changeset found

Latest commit: dc824b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MarceloPrado
Copy link
Owner

Looks great! Can you also add a story to test the functionality?

@isaiasdearcog
Copy link
Author

isaiasdearcog commented Dec 26, 2024

I actually saw you suggested this should be able at any level on theming, which makes a lot of sense, and I would like to work on that contribution! I'll see if I can work on that over the weekend :). Can you please show me an example of tests for components so I can build test suites for this feature? When I worked on this I wanted to add the test but I couldn't find any component tests.

@isaiasdearcog
Copy link
Author

@MarceloPrado friendly reminder of the comment above!

@hugoh59
Copy link

hugoh59 commented Jan 16, 2025

Hey @MarceloPrado, can we move forward with this PR? Would love to include it in my next release! Thank you.

@hugoh59
Copy link

hugoh59 commented Jan 29, 2025

I wish I could approve this PR!

@isaiasdearcog
Copy link
Author

@MarceloPrado i see the package has been gaining some popularity lately! If you are interested on supporting this, let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants