Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For some reason, we were still starting Location IDs at 501. Let's not do that. #90

Merged
merged 1 commit into from
Oct 5, 2024
Merged

For some reason, we were still starting Location IDs at 501. Let's not do that. #90

merged 1 commit into from
Oct 5, 2024

Conversation

silasary
Copy link
Collaborator

No description provided.

nicopop
nicopop approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@nicopop nicopop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I missed that in my #73 lol

@silasary
Copy link
Collaborator Author

Yeah, I only noticed it when implementing ID skips in XIV, and it was like "50 is lower than 526"

@FuzzyGamesOn
Copy link
Collaborator

We'll probably want to do another unstable release with this in it, so people can test the new ids without this bug. Good find, btw! 😃

@silasary silasary requested a review from FuzzyGamesOn October 4, 2024 05:23
FuzzyGamesOn
FuzzyGamesOn approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@FuzzyGamesOn FuzzyGamesOn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this probably should've been changed a long time ago. Not sure it was ever needed 😃

@silasary
Copy link
Collaborator Author

silasary commented Oct 5, 2024

It wasn't :D

@silasary silasary merged commit bc17094 into main Oct 5, 2024
@silasary silasary deleted the location_index branch October 5, 2024 01:50
@silasary silasary restored the location_index branch November 19, 2024 07:59
@silasary silasary deleted the location_index branch December 2, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicopop nicopop nicopop approved these changes

@axxroytovu axxroytovu axxroytovu approved these changes

@FuzzyGamesOn FuzzyGamesOn FuzzyGamesOn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silasary @FuzzyGamesOn @nicopop @axxroytovu