Implement Events #141
Open
Implement Events #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds event visibility to the slot data Checks the slot data to read which events should be visible Adds events that are visible to the item list with appropriate categories
|
Ok, we're very close. Events now have an optional "visible" tag that will make all copies of that event visible in the client. Still to-do:
|
nicopop
previously approved these changes
Mar 29, 2025
FuzzyGamesOn
added
the
paused for client updates
nicopop
approved these changes
Apr 18, 2025
Closed
FuzzyGamesOn
removed
the
paused for client updates
|
Removed the client paused label from this PR. At a glance, looks like a great addition. Will circle back to review. Ideally, we'd have some user-facing documentation to explain the new events feature, as this is likely to get a lot of use. I feel like you had documentation already for doing events in a Manual apworld, so might be able to repurpose some of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.