Skip to content

Commit 0dc9d06

Browse files
committed
realized from the upgrade steps that Manual's filler placement at the end of the pool wasn't using the get_filler_item_name method
1 parent 958874e commit 0dc9d06

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/__init__.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,9 @@ def create_items(self):
105105
configured_item_names = self.item_id_to_name.copy()
106106

107107
for name in configured_item_names.values():
108+
# victory gets placed via place_locked_item at the victory location in create_regions
108109
if name == "__Victory__": continue
110+
# the game.json filler item name is added to the item lookup, so skip it until it's potentially needed later
109111
if name == filler_item_name: continue
110112

111113
item = self.item_name_to_item[name]
@@ -355,8 +357,10 @@ def adjust_filler_items(self, item_pool, traps):
355357
extra_item = self.create_item(self.random.choice(traps))
356358
item_pool.append(extra_item)
357359

360+
filler_name_to_add = self.get_filler_item_name()
361+
358362
for _ in range(0, filler_count):
359-
extra_item = self.create_item(filler_item_name)
363+
extra_item = self.create_item(filler_name_to_add)
360364
item_pool.append(extra_item)
361365
elif extras < 0:
362366
logging.warning(f"{self.game} has more items than locations. {abs(extras)} non-progression items will be removed at random.")

0 commit comments

Comments
 (0)