Conversation
The two error messages in _throw_error_if_no_submobjects and _get_submobjects_with_points hardcoded the string "CurvesAsSubmobjects". Use type(self).__name__ so the message automatically reflects subclasses and stays correct if the class is ever renamed. Fixes ManimCommunity#4983
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4983.
The two error messages in
_throw_error_if_no_submobjectsand_get_submobjects_with_pointshardcoded the string"CurvesAsSubmobjects". This PR usestype(self).__name__so the message automatically reflects any subclass and stays correct if the class is ever renamed (matching the existing pattern inMobject.throw_error_if_no_points).Changes
manim/mobject/types/vectorized_mobject.py: replace the hardcoded class name withcls = type(self).__name__in both error messages.tests/module/mobject/types/vectorized_mobject/test_vectorized_mobject.py: addedtest_curves_as_submobjects_error_message_uses_dynamic_class_name, which subclassesCurvesAsSubmobjectsand asserts the error reports the subclass name and no longer contains the hardcoded string.Test
2 passed.