Skip to content

Add type annotations to tex_mobject.py #4355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 29, 2025
Merged

Add type annotations to tex_mobject.py #4355

merged 8 commits into from
Jul 29, 2025

Conversation

henrikmidtiby
Copy link
Contributor

Overview: What does this pull request change?

This PR adds type annotations to the tex_mobject.py file.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Jul 28, 2025
@henrikmidtiby henrikmidtiby marked this pull request as ready for review July 28, 2025 11:00
chopan050
chopan050 requested changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left 2 suggestions:

@github-project-automation github-project-automation bot moved this from 🆕 New to 👀 In review in Dev Board Jul 28, 2025
chopan050
chopan050 approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-project-automation github-project-automation bot moved this from 👀 In review to 👍 To be merged in Dev Board Jul 29, 2025
@chopan050 chopan050 changed the title Typing tex_mobject.py Add type annotations to tex_mobject.py Jul 29, 2025
@chopan050 chopan050 enabled auto-merge (squash) July 29, 2025 12:00
@chopan050 chopan050 merged commit df36f4f into ManimCommunity:main Jul 29, 2025
21 of 22 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Jul 29, 2025
@chopan050 chopan050 mentioned this pull request Jul 29, 2025
Closed
3 tasks
chopan050 added a commit that referenced this pull request Jul 29, 2025
@chopan050
Revert "Add type annotations to tex_mobject.py (#4355)"
75ba8c0 
This reverts commit df36f4f.
@chopan050
Copy link
Contributor

@henrikmidtiby An issue happened when building the docs. I enabled the automerge of this PR in case all required checks pass, but I see that building the docs seems to be not required for merging, so a bug was just merged...

Investigating further, it's because the default value of BulletedList.__init__()'s parameter tex_environment was changed from None to "", which tex_to_svg_file() does not recognize.

Could you please make a quick emergency PR to revert that change and type tex_environment in SingleStringMathTex, MathTex, Tex and BulletedList as str | None?

@henrikmidtiby henrikmidtiby mentioned this pull request Jul 29, 2025
Merged
3 tasks
@henrikmidtiby
Copy link
Contributor Author

@chopan050 Here you are #4358

@henrikmidtiby henrikmidtiby deleted the TypingTexMobject branch July 29, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chopan050 chopan050 chopan050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Dev Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrikmidtiby @chopan050